mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Roland Dreier <roland@topspin.com>
Cc: linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: Re: [PATCH][RFC/v1][4/12] Add InfiniBand SA (Subnet Administration) query support
Date: Mon, 22 Nov 2004 20:33:50 +0100	[thread overview]
Message-ID: <20041122193350.GB8150@mars.ravnborg.org> (raw)
In-Reply-To: <20041122713.g6bh6aqdXIN4RJYR@topspin.com>

Nitpicking.

	Sam
	
> --- linux-bk.orig/drivers/infiniband/core/Makefile	2004-11-21 21:25:53.101323036 -0800
> +++ linux-bk/drivers/infiniband/core/Makefile	2004-11-21 21:25:53.879207651 -0800
> @@ -2,7 +2,8 @@
>  
>  obj-$(CONFIG_INFINIBAND) += \
>      ib_core.o \
> -    ib_mad.o
> +    ib_mad.o \
> +    ib_sa.o
It's more readable to keep .o files on one line.


>  
>  ib_core-objs := \
>      packer.o \

For new stuff please use ib_core-y :=

> @@ -17,3 +18,5 @@
>      mad.o \
>      smi.o \
>      agent.o
> +
> +ib_sa-objs := sa_query.o
ib_sa-y := please.

> +#include <linux/idr.h>
> +
> +#include <ib_pack.h>
> +#include <ib_sa.h>
If they are in same dir as .c file use:
#include "ib_pack.h"
#include "ib_sa.h"

> Index: linux-bk/drivers/infiniband/include/ib_sa.h

.h files for a subsystem like this ought to be placed in include/infiniband
if they will be used by files in other directories than drivers/infiniband



  reply	other threads:[~2004-11-22 19:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20041122713.SDrx8l5Z4XR5FsjB@topspin.com>
2004-11-22 15:13 ` Roland Dreier
2004-11-22 19:33   ` Sam Ravnborg [this message]
2004-11-22 21:28     ` Roland Dreier
2004-11-22 22:25   ` Greg KH
2004-11-22 22:40     ` [openib-general] Re: [PATCH][RFC/v1][4/12] Add InfiniBand SA(Subnet " Fab Tillier
2004-11-22 23:34     ` [PATCH][RFC/v1][4/12] Add InfiniBand SA (Subnet " Roland Dreier
2004-11-23  6:41       ` Greg KH
2004-11-23  6:47         ` Roland Dreier
2004-11-23  7:29           ` Greg KH
2004-11-23 17:52             ` [openib-general] " Johannes Erdfelt
2004-11-23 18:38               ` Greg KH
2004-11-23 18:56                 ` Roland Dreier
2004-11-23 19:01                   ` Greg KH
2004-11-23 19:13                 ` Johannes Erdfelt
2004-11-23 19:30                 ` linux-os
2004-11-23 19:42                   ` Greg KH
2004-11-24 19:23                 ` Roland Dreier
2004-11-24 19:29                   ` Greg KH
2004-11-23 15:27         ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041122193350.GB8150@mars.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openib-general@openib.org \
    --cc=roland@topspin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®