From: Sam Ravnborg <sam@ravnborg.org>
To: Roland Dreier <roland@topspin.com>
Cc: linux-kernel@vger.kernel.org, openib-general@openib.org,
netdev@oss.sgi.com
Subject: Re: [PATCH][RFC/v1][8/12] Add IPoIB (IP-over-InfiniBand) driver
Date: Mon, 22 Nov 2004 20:40:03 +0100 [thread overview]
Message-ID: <20041122194003.GC8150@mars.ravnborg.org> (raw)
In-Reply-To: <20041122714.nKCPmH9LMhT0X7WE@topspin.com>
More nitpicking..
Sam
> +++ linux-bk/drivers/infiniband/Makefile 2004-11-21 21:25:56.794775182 -0800
> @@ -1,2 +1,3 @@
> obj-$(CONFIG_INFINIBAND) += core/
No reason to use $(CONFIG_INFINIBAND) here - it's already done in
drivers/infiniband/Makefile
> +EXTRA_CFLAGS += -Idrivers/infiniband/include
This will get killed if you move the include files...
+
> +obj-$(CONFIG_INFINIBAND_IPOIB) += ib_ipoib.o
> +
> +ib_ipoib-y := ipoib_main.o \
> + ipoib_ib.o \
> + ipoib_multicast.o \
> + ipoib_verbs.o \
> + ipoib_vlan.o
One or two lines.
> +#include <asm/semaphore.h>
> +
> +#include "ipoib_proto.h"
Shoulb be included as the last file - since it's the most local one.
> +
> +#include <ib_verbs.h>
> +#include <ib_pack.h>
> +#include <ib_sa.h>
>
next prev parent reply other threads:[~2004-11-22 19:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20041122713.cSeT4UFKGqJDdZ8T@topspin.com>
2004-11-22 15:13 ` [PATCH][RFC/v1][6/12] IPoIB IPv4 multicast Roland Dreier
2004-11-22 15:13 ` [PATCH][RFC/v1][7/12] IPoIB IPv6 support Roland Dreier
2004-11-22 15:14 ` [PATCH][RFC/v1][8/12] Add IPoIB (IP-over-InfiniBand) driver Roland Dreier
2004-11-22 15:14 ` [PATCH][RFC/v1][9/12] Add InfiniBand userspace MAD support Roland Dreier
2004-11-22 15:14 ` [PATCH][RFC/v1][10/12] Document InfiniBand ioctl use Roland Dreier
2004-11-22 15:14 ` [PATCH][RFC/v1][11/12] Add InfiniBand Documentation files Roland Dreier
2004-11-22 15:14 ` [PATCH][RFC/v1][12/12] InfiniBand MAINTAINERS entry Roland Dreier
2004-11-22 15:31 ` [PATCH][RFC/v1][11/12] Add InfiniBand Documentation files Christoph Hellwig
2004-11-22 15:41 ` Roland Dreier
2004-11-23 8:49 ` [openib-general] " Eric W. Biederman
2004-11-22 22:53 ` Greg KH
2004-11-22 22:58 ` Roland Dreier
2004-11-22 23:05 ` Greg KH
2004-11-22 23:21 ` Roland Dreier
2004-11-22 23:30 ` [openib-general] " Johannes Erdfelt
2004-11-23 6:45 ` Greg KH
2004-11-23 6:51 ` Johannes Erdfelt
2004-11-23 7:38 ` Greg KH
2004-11-22 22:50 ` [PATCH][RFC/v1][9/12] Add InfiniBand userspace MAD support Greg KH
2004-11-22 23:05 ` Roland Dreier
2004-11-23 7:45 ` Greg KH
2004-11-23 15:04 ` Roland Dreier
2004-11-23 2:08 ` Roland Dreier
2004-11-23 6:30 ` Greg KH
2004-11-23 6:45 ` Roland Dreier
2004-11-23 7:43 ` Greg KH
2004-11-23 15:06 ` Roland Dreier
2004-11-23 15:17 ` Greg KH
2004-11-22 19:40 ` Sam Ravnborg [this message]
2004-11-22 22:34 ` [PATCH][RFC/v1][8/12] Add IPoIB (IP-over-InfiniBand) driver Greg KH
2004-11-22 23:18 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041122194003.GC8150@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=openib-general@openib.org \
--cc=roland@topspin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®