From: Tejun Heo <tj@home-tj.org>
To: greg@kroah.com, rusty@rustcorp.com.au, linux-kernel@vger.kernel.org
Subject: [PATCH REPOST 2.6.10-rc2 0/4] module sysfs: module sysfs related clean ups
Date: Tue, 23 Nov 2004 15:12:52 +0900 [thread overview]
Message-ID: <20041123061252.GA14209@home-tj.org> (raw)
Hello, Greg. Hello, Rusty.
I forgot kfree(mk) in params.c:kernel_param_sysfs_setup() on failure
path. You can just add kfree(mk) like the following.
/* no need to keep the kobject if no parameter is exported */
- if (!param_sysfs_setup(mk, kparam, num_params, name_skip))
+ if (!param_sysfs_setup(mk, kparam, num_params, name_skip)) {
kobject_unregister(&mk->kobj);
+ kfree(mk);
+ }
I also regenerated all patches. Sorry for the inconvenience.
--
tejun
next reply other threads:[~2004-11-23 6:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-23 6:12 Tejun Heo [this message]
2004-11-23 6:13 ` [PATCH REPOST 2.6.10-rc2 1/4] module sysfs: make module.mkobj inline Tejun Heo
2004-11-23 6:14 ` [PATCH REPOST 2.6.10-rc2 0/4] module sysfs: expand module_attribute Tejun Heo
2004-11-23 6:18 ` This is 2/4, sorry Tejun Heo
2004-11-23 6:15 ` [PATCH REPOST 2.6.10-rc2 3/4] module sysfs: sections attr reimplemented using attr group Tejun Heo
2004-11-23 6:16 ` [PATCH REPOST 2.6.10-rc2 4/4] module sysfs: module parameters " Tejun Heo
2004-12-15 19:21 ` [PATCH REPOST 2.6.10-rc2 0/4] module sysfs: module sysfs related clean ups Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041123061252.GA14209@home-tj.org \
--to=tj@home-tj.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®