From: Roger Luethi <rl@hellgate.ch>
To: Greg KH <greg@kroah.com>
Cc: Simon Fowler <simon@himi.org>, linux-kernel@vger.kernel.org
Subject: [2.6 PATCH] visor: Don't count outstanding URBs twice
Date: Tue, 23 Nov 2004 20:36:04 +0100 [thread overview]
Message-ID: <20041123193604.GA12605@k3.hellgate.ch> (raw)
In-Reply-To: <20041119174405.GE20162@kroah.com>
Guys, can you please CC me when discussing patches of mine? I don't read
LKML religiously, and my procmail filters are pretty dumb. Thanks. So
my previous patch fixed the oops, but the driver's still borked.
Incrementing the outstanding_urbs counter twice for the same URB can't
be good. No wonder Simon didn't get far syncing his Palm.
Signed-off-by: Roger Luethi <rl@hellgate.ch>
--- linux-2.6.10-rc2-bk8/drivers/usb/serial/visor.c.orig 2004-11-23 20:23:27.592097112 +0100
+++ linux-2.6.10-rc2-bk8/drivers/usb/serial/visor.c 2004-11-23 20:24:53.496037728 +0100
@@ -497,7 +497,6 @@ static int visor_write (struct usb_seria
dev_dbg(&port->dev, "write limit hit\n");
return 0;
}
- ++priv->outstanding_urbs;
spin_unlock_irqrestore(&priv->lock, flags);
buffer = kmalloc (count, GFP_ATOMIC);
next prev parent reply other threads:[~2004-11-23 19:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-16 15:49 [2.6 PATCH] visor: Always do generic_startup Roger Luethi
2004-11-19 17:44 ` Greg KH
2004-11-21 1:23 ` Simon Fowler
2004-11-21 4:08 ` Greg KH
2004-11-21 7:15 ` Simon Fowler
2004-11-22 18:54 ` Greg KH
2004-11-23 19:36 ` Roger Luethi [this message]
2004-11-23 19:45 ` [2.6 PATCH] visor: Don't count outstanding URBs twice Greg KH
2004-11-23 20:30 ` Roger Luethi
2004-11-24 0:40 ` Simon Fowler
2004-11-24 23:25 ` Greg KH
2004-11-25 16:16 ` [2.6 PATCH] visor: Make URB limit error more visible Roger Luethi
2004-11-25 18:06 ` Greg KH
2004-11-28 17:11 ` Alan Cox
2004-11-30 0:06 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041123193604.GA12605@k3.hellgate.ch \
--to=rl@hellgate.ch \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=simon@himi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome