From: David Brownell <david-b@pacbell.net>
To: linux-usb-devel@lists.sourceforge.net
Cc: Colin Leroy <colin@colino.net>,
linux-kernel@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Greg KH <greg@kroah.com>
Subject: Re: [linux-usb-devel] [PATCH] Ohci-hcd: fix endless loop
Date: Fri, 26 Nov 2004 09:21:26 -0800 [thread overview]
Message-ID: <200411260921.26628.david-b@pacbell.net> (raw)
In-Reply-To: <20041126175454.17b62cf5@pirandello>
On Friday 26 November 2004 08:54, Colin Leroy wrote:
> On 26 Nov 2004 at 08h11, David Brownell wrote:
>
> Hi,
>
> > The infinite loop means that something trashed the stack, yes?
> >
> > The "limit-- < -1000" test below should never be able to succeed
> > unless the previous "limit-- == 0" test got trashed by having
> > something obliterate the stack.
>
> Sure? the (limit -- == 0) gotoes higher to test again.
> from what I understand the loop goes back to rescan 1000 times, then once
> to sanitize, then to back to rescan again infinetely...
> I may be wrong but I don't think there's a stack corruption there.
The "limit" isn't tested a 1001st time, since the ED state
changed.
For that matter, any time that the IRQ lossage appears,
there's always been something that damaged the IRQ setup.
- Dave
next prev parent reply other threads:[~2004-11-27 6:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-25 18:17 Colin Leroy
2004-11-26 16:38 ` [linux-usb-devel] " David Brownell
2004-11-26 16:54 ` Colin Leroy
2004-11-26 17:21 ` David Brownell [this message]
2004-11-26 22:07 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200411260921.26628.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=benh@kernel.crashing.org \
--cc=colin@colino.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome