mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dipankar Sarma <dipankar@in.ibm.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: linux-kernel@vger.kernel.org,
	Manfred Spraul <manfred@colorfullife.com>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 1/2] rcu: cosmetic, delete wrong comment, use HARDIRQ_OFFSET
Date: Sun, 28 Nov 2004 20:49:25 +0530	[thread overview]
Message-ID: <20041128151925.GA20894@in.ibm.com> (raw)
In-Reply-To: <41A9E98C.2C1D07EF@tv-sign.ru>

On Sun, Nov 28, 2004 at 06:06:52PM +0300, Oleg Nesterov wrote:
> Hello.
> 
> rcu_check_quiescent_state:
> 	/*
> 	 * Races with local timer interrupt - in the worst case
> 	 * we may miss one quiescent state of that CPU. That is
> 	 * tolerable. So no need to disable interrupts.
> 	 */
> 	if (rdp->qsctr == rdp->last_qsctr)
> 		return;
> 
> Afaics, this comment is misleading. rcu_check_quiescent_state()
> is executed in softirq context, while rcu_check_callbacks() checks
> in_softirq() before ++qsctr.
> 
> Also, replace (1 << HARDIRQ_SHIFT) by HARDIRQ_OFFSET.
> 

Looks good to me. IIRC, that comment has been around since very
early prototypes, so it is probably leftover trash.

Thanks
Dipankar

  parent reply	other threads:[~2004-11-28 15:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-28 15:06 Oleg Nesterov
2004-11-28 14:31 ` William Lee Irwin III
2004-11-28 16:06   ` Oleg Nesterov
2004-11-28 15:19 ` Dipankar Sarma [this message]
2004-11-28 15:24   ` Manfred Spraul
2004-11-28 15:42     ` Dipankar Sarma
2004-11-28 17:36       ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041128151925.GA20894@in.ibm.com \
    --to=dipankar@in.ibm.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    --cc=oleg@tv-sign.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®