From: Patrick Caulfield <patrick@tykepenguin.com>
To: davem@redhat.com
Cc: linux-kernel@vger.kernel.org,
DECnet list <linux-decnet-user@lists.sourceforge.net>
Subject: [PATCH 2.6] DECnet typo in accept causes oops
Date: Mon, 29 Nov 2004 16:05:22 +0000 [thread overview]
Message-ID: <20041129160522.GP16269@tykepenguin.com> (raw)
This patch fixes typo which can cause a rare oops in accept. dn_accept returns
a pointer instead of an error if dn_wait_for_connect() is interrupted.
This confuses sys_accept which calls dn_getname with a incomplete struct socket,
this then oopses.
patrick
Signed-off-by: Patrick Caulfield <patrick@tykepenguin.com>
===== net/decnet/af_decnet.c 1.45 vs edited =====
--- 1.45/net/decnet/af_decnet.c 2004-11-06 07:43:31 +00:00
+++ edited/net/decnet/af_decnet.c 2004-11-29 15:56:40 +00:00
@@ -1075,7 +1075,7 @@ static int dn_accept(struct socket *sock
skb = dn_wait_for_connect(sk, &timeo);
if (IS_ERR(skb)) {
release_sock(sk);
- return PTR_ERR(sk);
+ return PTR_ERR(skb);
}
}
next reply other threads:[~2004-11-29 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-29 16:05 Patrick Caulfield [this message]
2004-11-30 3:56 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041129160522.GP16269@tykepenguin.com \
--to=patrick@tykepenguin.com \
--cc=davem@redhat.com \
--cc=linux-decnet-user@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®