From: Sam Ravnborg <sam@ravnborg.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] move OSS ac97_codec.h to sound/oss/
Date: Tue, 30 Nov 2004 06:32:28 +0100 [thread overview]
Message-ID: <20041130053228.GB8211@mars.ravnborg.org> (raw)
In-Reply-To: <20041130013139.GC19821@stusta.de>
On Tue, Nov 30, 2004 at 02:31:39AM +0100, Adrian Bunk wrote:
--- linux-2.6.10-rc2-mm3-full/sound/oss/emu10k1/hwaccess.h.old 2004-11-30 02:11:21.000000000 +0100
> +++ linux-2.6.10-rc2-mm3-full/sound/oss/emu10k1/hwaccess.h 2004-11-30 02:12:16.000000000 +0100
> @@ -35,7 +35,7 @@
> #include <linux/fs.h>
> #include <linux/sound.h>
> #include <linux/soundcard.h>
> -#include <linux/ac97_codec.h>
> +#include "../ac97_codec.h"
Such relative includes should be avoided. Set CFLAGS_xxx.o in Makefile instead.
And move include down under #include <asm/xxx>
Sam
prev parent reply other threads:[~2004-11-30 5:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-30 1:31 Adrian Bunk
2004-11-30 1:37 ` Al Viro
2004-11-30 1:52 ` Adrian Bunk
2004-11-30 15:54 ` Alan Cox
2004-11-30 17:56 ` Jeff Garzik
2004-11-30 5:32 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041130053228.GB8211@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®