From: "Randy.Dunlap" <rddunlap@osdl.org>
To: sclin@sis.com.tw, lkml <linux-kernel@vger.kernel.org>
Cc: dri-devel@lists.sourceforge.net, akpm <akpm@osdl.org>
Subject: [PATCH] SIS DRM bool. bitfields
Date: Tue, 30 Nov 2004 16:51:03 -0800 [thread overview]
Message-ID: <20041130165103.5ca0b428.rddunlap@osdl.org> (raw)
(resend)
Make 1-bit fields be unsigned (no sign bit :).
sparse complains about them:
drivers/char/drm/sis_ds.h:88:12: warning: dubious one-bit signed bitfield
drivers/char/drm/sis_ds.h:89:16: warning: dubious one-bit signed bitfield
Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
diffstat:=
drivers/char/drm/sis_ds.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -Naurp ./drivers/char/drm/sis_ds.h~sis_bits ./drivers/char/drm/sis_ds.h
--- ./drivers/char/drm/sis_ds.h~sis_bits 2004-08-13 22:36:57.000000000 -0700
+++ ./drivers/char/drm/sis_ds.h 2004-10-11 07:59:31.861263400 -0700
@@ -85,8 +85,8 @@ struct mem_block_t {
struct mem_block_t *heap;
int ofs,size;
int align;
- int free:1;
- int reserved:1;
+ unsigned int free:1;
+ unsigned int reserved:1;
};
typedef struct mem_block_t TMemBlock;
typedef struct mem_block_t *PMemBlock;
---
reply other threads:[~2004-12-01 1:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041130165103.5ca0b428.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=akpm@osdl.org \
--cc=dri-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sclin@sis.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®