mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] inotify: a replacement for dnotify
Date: Wed, 1 Dec 2004 10:07:49 -0800	[thread overview]
Message-ID: <20041201100748.L14339@build.pdx.osdl.net> (raw)
In-Reply-To: <Pine.LNX.4.53.0412010937500.17975@yvahk01.tjqt.qr>; from jengelh@linux01.gwdg.de on Wed, Dec 01, 2004 at 09:38:17AM +0100

* Jan Engelhardt (jengelh@linux01.gwdg.de) wrote:
> >> +	user = find_user(current->user->uid);
> >> +	if (!user)
> >> +		return -ENOMEM;
> >
> >Can just be:
> >
> >	get_uid(current->user);
> 
> What about current->euid?

Not relevant.  There's only one user_struct per task_struct.  The change
is to simply grab a ref on it and go rather than doing a full look up
in the uid hash as a method to get a refcount on it.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

  reply	other threads:[~2004-12-01 18:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-30 22:34 Robert Love
2004-11-30 23:03 ` Chris Wright
2004-12-01  8:38   ` Jan Engelhardt
2004-12-01 18:07     ` Chris Wright [this message]
2004-12-01 18:48   ` Robert Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041201100748.L14339@build.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=jengelh@linux01.gwdg.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®