From: "Randy.Dunlap" <rddunlap@osdl.org>
To: minyard@mvista.com, akpm <akpm@osdl.org>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] IPMI: use C99 struct inits.
Date: Wed, 1 Dec 2004 11:45:38 -0800 [thread overview]
Message-ID: <20041201114538.195ea302.rddunlap@osdl.org> (raw)
Convert IPMI driver struct usage to C99 initializers.
Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
diffstat:=
drivers/char/ipmi/ipmi_msghandler.c | 6 +++---
drivers/char/ipmi/ipmi_poweroff.c | 12 +++++++++---
drivers/char/ipmi/ipmi_watchdog.c | 24 ++++++++++++------------
3 files changed, 24 insertions(+), 18 deletions(-)
diff -Naurp ./drivers/char/ipmi/ipmi_msghandler.c~ipmi_c99 ./drivers/char/ipmi/ipmi_msghandler.c
--- ./drivers/char/ipmi/ipmi_msghandler.c~ipmi_c99 2004-10-18 14:54:32.000000000 -0700
+++ ./drivers/char/ipmi/ipmi_msghandler.c 2004-12-01 10:41:59.876793120 -0800
@@ -3126,9 +3126,9 @@ static int panic_event(struct notifier_b
}
static struct notifier_block panic_block = {
- panic_event,
- NULL,
- 200 /* priority: INT_MAX >= x >= 0 */
+ .notifier_call = panic_event,
+ .next = NULL,
+ .priority = 200 /* priority: INT_MAX >= x >= 0 */
};
static int ipmi_init_msghandler(void)
diff -Naurp ./drivers/char/ipmi/ipmi_poweroff.c~ipmi_c99 ./drivers/char/ipmi/ipmi_poweroff.c
--- ./drivers/char/ipmi/ipmi_poweroff.c~ipmi_c99 2004-10-18 14:54:32.000000000 -0700
+++ ./drivers/char/ipmi/ipmi_poweroff.c 2004-12-01 11:01:54.147236416 -0800
@@ -381,11 +381,17 @@ struct poweroff_function {
};
static struct poweroff_function poweroff_functions[] = {
- { "ATCA", ipmi_atca_detect, ipmi_poweroff_atca },
- { "CPI1", ipmi_cpi1_detect, ipmi_poweroff_cpi1 },
+ { .platform_type = "ATCA",
+ .detect = ipmi_atca_detect,
+ .poweroff_func = ipmi_poweroff_atca },
+ { .platform_type = "CPI1",
+ .detect = ipmi_cpi1_detect,
+ .poweroff_func = ipmi_poweroff_cpi1 },
/* Chassis should generally be last, other things should override
it. */
- { "chassis", ipmi_chassis_detect, ipmi_poweroff_chassis },
+ { .platform_type = "chassis",
+ .detect = ipmi_chassis_detect,
+ .poweroff_func = ipmi_poweroff_chassis },
};
#define NUM_PO_FUNCS (sizeof(poweroff_functions) \
/ sizeof(struct poweroff_function))
diff -Naurp ./drivers/char/ipmi/ipmi_watchdog.c~ipmi_c99 ./drivers/char/ipmi/ipmi_watchdog.c
--- ./drivers/char/ipmi/ipmi_watchdog.c~ipmi_c99 2004-10-18 14:55:28.000000000 -0700
+++ ./drivers/char/ipmi/ipmi_watchdog.c 2004-12-01 11:43:58.154528984 -0800
@@ -518,9 +518,9 @@ static void panic_halt_ipmi_heartbeat(vo
static struct watchdog_info ident=
{
- 0, /* WDIOF_SETTIMEOUT, */
- 1,
- "IPMI"
+ .options = 0, /* WDIOF_SETTIMEOUT, */
+ .firmware_version = 1,
+ .identity = "IPMI"
};
static int ipmi_ioctl(struct inode *inode, struct file *file,
@@ -748,9 +748,9 @@ static struct file_operations ipmi_wdog_
};
static struct miscdevice ipmi_wdog_miscdev = {
- WATCHDOG_MINOR,
- "watchdog",
- &ipmi_wdog_fops
+ .minor = WATCHDOG_MINOR,
+ .name = "watchdog",
+ .fops = &ipmi_wdog_fops
};
static DECLARE_RWSEM(register_sem);
@@ -885,9 +885,9 @@ static int wdog_reboot_handler(struct no
}
static struct notifier_block wdog_reboot_notifier = {
- wdog_reboot_handler,
- NULL,
- 0
+ .notifier_call = wdog_reboot_handler,
+ .next = NULL,
+ .priority = 0
};
extern int panic_timeout; /* Why isn't this defined anywhere? */
@@ -915,9 +915,9 @@ static int wdog_panic_handler(struct not
}
static struct notifier_block wdog_panic_notifier = {
- wdog_panic_handler,
- NULL,
- 150 /* priority: INT_MAX >= x >= 0 */
+ .notifier_call = wdog_panic_handler,
+ .next = NULL,
+ .priority = 150 /* priority: INT_MAX >= x >= 0 */
};
---
next reply other threads:[~2004-12-01 19:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-01 19:45 Randy.Dunlap [this message]
2004-12-02 2:16 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041201114538.195ea302.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®