mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: "Adam J. Richter" <adam@yggdrasil.com>
Cc: maneesh@in.ibm.com, greg@kroah.com, linux-kernel@vger.kernel.org
Subject: Re: [Patch] Delete sysfs_dirent.s_count, saving ~100kB on my system
Date: Wed, 1 Dec 2004 13:07:03 -0800	[thread overview]
Message-ID: <20041201130703.79a3f3b5.akpm@osdl.org> (raw)
In-Reply-To: <200412011856.iB1IuAc21682@adam.yggdrasil.com>

"Adam J. Richter" <adam@yggdrasil.com> wrote:
>
> 	Here is a rewrite of my patch to remove sysfs_dirent.s_count,
>  reducing the memory chunk that kmalloc uses for sysfs_dirent from
>  64 to 32 bytes, thereby saving about 120kB for the 3700+ nodes in
>  /sys on the ordinary PC on which I am typing this message.

That's all well and good, but sysfs_new_dirent() should be using a
standalone slab cache for allocating sysfs_dirent instances.  That way, we
use 36 bytes for each one rather than 64.

  reply	other threads:[~2004-12-01 21:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-01 18:56 Adam J. Richter
2004-12-01 21:07 ` Andrew Morton [this message]
2004-12-01 23:51   ` Chris Wright
2004-12-17 23:27     ` Greg KH
2004-12-30 13:34 ` Maneesh Soni
  -- strict thread matches above, loose matches on Subject: below --
2004-12-02  2:59 Adam J. Richter
2004-11-23  4:08 Adam J. Richter
2004-11-22 19:17 Adam J. Richter
2004-11-22 22:53 ` Maneesh Soni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041201130703.79a3f3b5.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=adam@yggdrasil.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maneesh@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome