From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261546AbULBG5C (ORCPT ); Thu, 2 Dec 2004 01:57:02 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261564AbULBG5C (ORCPT ); Thu, 2 Dec 2004 01:57:02 -0500 Received: from fw.osdl.org ([65.172.181.6]:20644 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S261546AbULBG5A (ORCPT ); Thu, 2 Dec 2004 01:57:00 -0500 Date: Wed, 1 Dec 2004 22:56:59 -0800 From: Chris Wright To: "Adam J. Richter" Cc: maneesh@in.ibm.com, akpm@osdl.org, chrisw@osdl.org, greg@kroah.com, linux-kernel@vger.kernel.org Subject: Re: [Patch?] Teach sysfs_get_name not to use a dentry Message-ID: <20041201225659.X2357@build.pdx.osdl.net> References: <200412020641.iB26f8W26315@adam.yggdrasil.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200412020641.iB26f8W26315@adam.yggdrasil.com>; from adam@yggdrasil.com on Wed, Dec 01, 2004 at 10:41:08PM -0800 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org * Adam J. Richter (adam@yggdrasil.com) wrote: > -static int create_dir(struct kobject * k, struct dentry * p, > - const char * n, struct dentry ** d) > +static int create_dir(void *element, struct dentry * p, > + const char * n, struct dentry ** d, int type) Hmm, I did not look closely, but moving from well-typed to untyped void * doesn't look nice. thanks, -chris -- Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net