mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Frank Denis (Jedi/Sector One)" <lkml@pureftpd.org>
To: Andrew Benton <andy@benton987.fsnet.co.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: reiser4 crash
Date: Sat, 4 Dec 2004 13:18:15 +0100	[thread overview]
Message-ID: <20041204121837.GA1998@c9x.org> (raw)
In-Reply-To: <41B1A3AA.5060703@benton987.fsnet.co.uk>

On Sat, Dec 04, 2004 at 11:46:50AM +0000, Andrew Benton wrote:
> I've been using reiser4 for a couple of months. A couple of days ago I
> did something stupid with Abiword, the disk started thrashing and as the
> system crashed it left this on the screen

  You need that patch.

diff -urN linux-2.6.10-rc2-mm4/fs/reiser4/plugin/file/file.c /usr/src/linux-2.6.10-rc2-mm4-jedi1/fs/reiser4/plugin/file/file.c
--- linux-2.6.10-rc2-mm4/fs/reiser4/plugin/file/file.c	2004-12-03 22:31:54.502630648 +0100
+++ /usr/src/linux-2.6.10-rc2-mm4-jedi1/fs/reiser4/plugin/file/file.c	2004-12-03 22:17:11.113926144 +0100
@@ -1741,6 +1741,8 @@
 	while (left > 0) {
 		size_t to_read;		
 
+		txn_restart_current();
+
 		size = i_size_read(inode);
 		if (*off >= size)
 			/* position to read from is past the end of file */
@@ -1774,7 +1776,6 @@
 		if (user_space)
 			reiser4_put_user_pages(pages, nr_pages);
 		drop_nonexclusive_access(uf_info);
-		txn_restart_current();
 
 		if (read < 0) {
 			result = read;
@@ -1975,6 +1976,8 @@
 	drop_nonexclusive_access(unix_file_inode_data(inode));
 	up_read(&reiser4_inode_data(inode)->coc_sem);
 
+	txn_restart_current();
+
 	reiser4_exit_context(&ctx);
 	return page;
 }

--
Frank - my stupid blog: http://00f.net

  reply	other threads:[~2004-12-04 12:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-04 11:46 Andrew Benton
2004-12-04 12:18 ` Frank Denis (Jedi/Sector One) [this message]
2004-12-04 12:20 ` Frank Denis (Jedi/Sector One)
2004-12-04 12:52 ` Mark Nipper
2004-12-04 13:52   ` Andrew Benton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041204121837.GA1998@c9x.org \
    --to=lkml@pureftpd.org \
    --cc=andy@benton987.fsnet.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®