From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261290AbULEKd2 (ORCPT ); Sun, 5 Dec 2004 05:33:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261292AbULEKd2 (ORCPT ); Sun, 5 Dec 2004 05:33:28 -0500 Received: from mx2.elte.hu ([157.181.151.9]:44729 "EHLO mx2.elte.hu") by vger.kernel.org with ESMTP id S261290AbULEKdY (ORCPT ); Sun, 5 Dec 2004 05:33:24 -0500 Date: Sun, 5 Dec 2004 11:33:17 +0100 From: Ingo Molnar To: Zwane Mwaikambo Cc: Linux Kernel , Andrew Morton , Andi Kleen Subject: Re: [PATCH] NX: Fix noexec kernel parameter / x86_64 Message-ID: <20041205103317.GB26964@elte.hu> References: <20041205065921.GA26964@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-ELTE-SpamVersion: MailScanner 4.31.6-itk1 (ELTE 1.2) SpamAssassin 2.63 ClamAV 0.73 X-ELTE-VirusStatus: clean X-ELTE-SpamCheck: no X-ELTE-SpamCheck-Details: score=-4.9, required 5.9, autolearn=not spam, BAYES_00 -4.90 X-ELTE-SpamLevel: X-ELTE-SpamScore: -4 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org * Zwane Mwaikambo wrote: > > > + if (!memcmp(from, "noexec=", 7)) { > > > + extern void nonx_setup(char *str); > > > + > > > + nonx_setup(from + 7); > > > + } > > > > looks good, but please put the prototype into a header. > > I bet Andrew is going to say the same thing... It just seems odd > putting a prototype in a header for a function with one call site and > gets freed after boot. Since i'll have to rediff, i'm also going to > change the nonx_setup parameter type to const char * as suggested by > someone in a private email. too many times did stuff break in the past due to some function changing some attribute later on but the prototype being misdefined in another place and the compiler having no chance to detect it. Ingo