mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr.zoreil.com>
To: Nicholas Papadakos <panic@quake.gr>
Cc: linux-kernel@vger.kernel.org
Subject: Re: realtek r8169 + kernel 2.4.24 (openmosix)
Date: Sun, 5 Dec 2004 13:24:14 +0100	[thread overview]
Message-ID: <20041205122414.GA22383@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <200412050124.iB51O6Ym014932@kane.otenet.gr>

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

Nicholas Papadakos <panic@quake.gr> :
[...]
> I commented out the line recompiled but still same problem.

gcc should spit one message less.

> I tried to apply the patch both in the older version and in the new one but
> nothing.

The tabs have been turned into spaces. Either add 'ull' to 0x0badbadbadbadbad
or apply the attached version (don't edit/copy/paste it if you are not sure
that the tabs are preserved).

[...]
> And yeah values greater than 1500 would improve openmosix a lot a believe.

A backport of the test version of the 2.6.x driver (SG, RX/TX csum, up to ~7000
bytes frames, patch against vanilla 2.4.28) is available at:
http://www.fr.zoreil.com/people/francois/misc/20041205-2.4.28-r8169.c-test.patch

For the curious one, the patchscript version can be found at:
http://www.fr.zoreil.com/linux/kernel/2.4.x/2.4.28

It compiles but it is completely untested. You should probably wait a bit until
I verify it is not trivially broken. Otoh, if you have some spare time...

--
Ueimor

[-- Attachment #2: r8169-mini-fix.patch --]
[-- Type: text/plain, Size: 393 bytes --]

--- drivers/net/r8169.c.orig	2004-12-04 18:22:18.000000000 +0100
+++ drivers/net/r8169.c	2004-12-04 18:22:37.000000000 +0100
@@ -1161,7 +1161,7 @@ rtl8169_hw_start(struct net_device *dev)
 
 static inline void rtl8169_make_unusable_by_asic(struct RxDesc *desc)
 {
-	desc->addr = 0x0badbadbadbadbad;
+	desc->addr = 0x0badbadbadbadbadull;
 	desc->status &= ~cpu_to_le32(OWNbit | RsvdMask);
 }
 

  reply	other threads:[~2004-12-05 12:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-03 21:29 Nicholas Papadakos
2004-12-04  0:26 ` Francois Romieu
2004-12-04 14:35   ` Nicholas Papadakos
2004-12-04 17:33     ` Francois Romieu
2004-12-04 22:41       ` Nicholas Papadakos
2004-12-05 12:24         ` Francois Romieu [this message]
2004-12-05 13:17           ` Nicholas Papadakos
2004-12-05 13:51             ` Francois Romieu
2004-12-06 23:41               ` Francois Romieu
2004-12-09  0:50                 ` Francois Romieu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041205122414.GA22383@electric-eye.fr.zoreil.com \
    --to=romieu@fr.zoreil.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=panic@quake.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®