From: Ingo Molnar <mingo@elte.hu>
To: Dimitri Sivanich <sivanich@sgi.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Jesse Barnes <jbarnes@sgi.com>,
piggin@cyberone.com.au
Subject: Re: [PATCH] isolcpus option broken in 2.6.10-rc2-bk2
Date: Mon, 6 Dec 2004 22:18:17 +0100 [thread overview]
Message-ID: <20041206211817.GB10235@elte.hu> (raw)
In-Reply-To: <20041206185221.GA23917@sgi.com>
* Dimitri Sivanich <sivanich@sgi.com> wrote:
> The isolcpus option is broken in 2.6.10-rc2-bk2. The domains are no longer
> being properly initialized (which results in a panic at bootup).
>
> The following patch fixes this.
>
> Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
Acked-by: Ingo Molnar <mingo@elte.hu>
only a minor nit:
> + /* Initialize isolated CPU (physical) domains and groups */
> + for_each_cpu_mask(i, cpu_isolated_map) {
> + struct sched_domain *sd = NULL;
there's no need to initialize 'sd' to NULL here.
> + int group;
> +
> + sd = &per_cpu(phys_domains, i);
> + group = cpu_to_phys_group(i);
> + for_each_cpu_mask(i, cpu_isolated_map) {
> + struct sched_domain *sd = NULL;
ditto.
> + int group;
> +
> + sd = &per_cpu(phys_domains, i);
> + group = cpu_to_phys_group(i);
> + *sd = SD_CPU_INIT;
Ingo
next prev parent reply other threads:[~2004-12-06 21:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-06 18:52 Dimitri Sivanich
2004-12-06 21:18 ` Ingo Molnar [this message]
2004-12-08 8:57 ` Nick Piggin
2004-12-08 9:04 ` Ingo Molnar
2004-12-07 22:59 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041206211817.GB10235@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=jbarnes@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=piggin@cyberone.com.au \
--cc=sivanich@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®