From: Andrew Morton <akpm@osdl.org>
To: Chris Wright <chrisw@osdl.org>
Cc: dave@sr71.net, linux-kernel@vger.kernel.org,
Manfred Spraul <manfred@colorfullife.com>
Subject: Re: oops in proc_pid_stat() on task->real_parent?
Date: Tue, 7 Dec 2004 22:18:21 -0800 [thread overview]
Message-ID: <20041207221821.068568f4.akpm@osdl.org> (raw)
In-Reply-To: <20041207220753.E469@build.pdx.osdl.net>
Chris Wright <chrisw@osdl.org> wrote:
>
> * Andrew Morton (akpm@osdl.org) wrote:
> > yup, we fixed that one.
>
> I thought the same thing, but this oops is from proc_pid_stat, not
> proc_pid_status. The code is now in do_task_stat(), and the oops is
> within the orignal tasklist lock (instead of dropping and reaquiring the
> lock). So, might be fixed, but if so, I think for a different reason.
>
Ah, thanks.
I'm not sure that the holding of tasklist_lock is going to save us there.
But then, Manfred recently did an audit, so I'm probably missing something.
Manfred, should we do this?
--- 25/fs/proc/array.c~do_task_stat-use-pid_alive 2004-12-07 22:17:01.378528576 -0800
+++ 25-akpm/fs/proc/array.c 2004-12-07 22:17:10.140196600 -0800
@@ -370,7 +370,7 @@ static int do_task_stat(struct task_stru
stime += task->signal->stime;
}
}
- ppid = task->pid ? task->group_leader->real_parent->tgid : 0;
+ ppid = pid_alive(task) ? task->group_leader->real_parent->tgid : 0;
read_unlock(&tasklist_lock);
if (!whole || num_threads<2)
_
next prev parent reply other threads:[~2004-12-08 6:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-08 0:55 Dave Hansen
2004-12-08 6:00 ` Andrew Morton
2004-12-08 6:07 ` Chris Wright
2004-12-08 6:18 ` Andrew Morton [this message]
2004-12-08 17:02 ` Chris Wright
2004-12-08 7:46 ` Dinakar Guniguntala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041207221821.068568f4.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=chrisw@osdl.org \
--cc=dave@sr71.net \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®