mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Patrick van de Lageweg <patrick@bitwizard.nl>
Cc: Linus Torvalds <torvalds@osdl.org>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	Rogier Wolff <R.E.Wolff@BitWizard.nl>,
	Eric Wood <eric@interplas.com>,
	bmckinlay@perle.com, tmckinlay@perle.com
Subject: Re: [PATCH] SX
Date: Wed, 8 Dec 2004 13:58:24 +0000	[thread overview]
Message-ID: <20041208135824.GC31975@infradead.org> (raw)
In-Reply-To: <20041208133000.GD19937@bitwizard.nl>

> +/* Not used anymore??? - PVDL */
> +#if 1
>  #ifdef CONFIG_PCI
>  static struct pci_device_id sx_pci_tbl[] = {
>  	{ PCI_VENDOR_ID_SPECIALIX, PCI_DEVICE_ID_SPECIALIX_SX_XIO_IO8, PCI_ANY_ID, PCI_ANY_ID },
> @@ -258,6 +260,7 @@
>  };
>  MODULE_DEVICE_TABLE(pci, sx_pci_tbl);
>  #endif /* CONFIG_PCI */
> +#endif

this is nessecary for installers to autoprobe the driver.  But you
should absolutely convert the driver to the pci_driver model so it's
used inside the driver aswell.


      reply	other threads:[~2004-12-08 13:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-08 13:30 Patrick van de Lageweg
2004-12-08 13:58 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041208135824.GC31975@infradead.org \
    --to=hch@infradead.org \
    --cc=R.E.Wolff@BitWizard.nl \
    --cc=bmckinlay@perle.com \
    --cc=eric@interplas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrick@bitwizard.nl \
    --cc=tmckinlay@perle.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®