mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: akpm@osdl.org
Cc: willschm@us.ibm.com, linux-kernel@vger.kernel.org
Subject: [PATCH] ppc64: Correct alignment for lppaca in paca_struct
Date: Fri, 10 Dec 2004 01:46:36 +1100	[thread overview]
Message-ID: <20041209144636.GB24640@krispykreme.ozlabs.ibm.com> (raw)
In-Reply-To: <20041209143428.GA24640@krispykreme.ozlabs.ibm.com>


Hi Andrew,

Sorry, last patch was mangled in some way.

I think this is 2.6.10 material, as well as lparcfg it fixes a nasty 
bug in our shared processor support (some cpus fail to recognise they
are in shared processor mode).

Anton

--

From: Will Schmidt <willschm@us.ibm.com>

We found that we were failing register_vpa calls in cases where the lppaca
structure (part of the PACA) crosses a page boundary.

This was causing us (lparcfg specifically) some grief as the xSharedProc bit 
was not being set.

The attached patch changes the alignment of the lppaca structure, and a few 
comments so we understand why.

Signed-off-by: Will Schmidt <willschm@us.ibm.com>
Signed-off-by: Anton Blanchard <anton@samba.org>

diff -puN include/asm-ppc64/paca.h~vpa_align include/asm-ppc64/paca.h
--- foobar2/include/asm-ppc64/paca.h~vpa_align	2004-12-10 01:40:32.325580252 +1100
+++ foobar2-anton/include/asm-ppc64/paca.h	2004-12-10 01:41:14.558646921 +1100
@@ -99,11 +99,13 @@ struct paca_struct {
 	u64 exdsi[8];		/* used for linear mapping hash table misses */
 
 	/*
-	 * iSeries structues which the hypervisor knows about - Not
-	 * sure if these particularly need to be cacheline aligned.
+	 * iSeries structues which the hypervisor knows about -
+	 * This structure should not cross a page boundary.
+	 * The vpa_init/register_vpa call is now known to fail if the lppaca
+	 * structure crosses a page boundary.
 	 * The lppaca is also used on POWER5 pSeries boxes.
 	 */
-	struct ItLpPaca lppaca __attribute__((aligned(0x80)));
+	struct ItLpPaca lppaca __attribute__((aligned(0x400)));
 #ifdef CONFIG_PPC_ISERIES
 	struct ItLpRegSave reg_save;
 #endif
_

      reply	other threads:[~2004-12-09 14:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-09 14:34 Anton Blanchard
2004-12-09 14:46 ` Anton Blanchard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041209144636.GB24640@krispykreme.ozlabs.ibm.com \
    --to=anton@samba.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=willschm@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®