From: Andrew Morton <akpm@osdl.org>
To: Zwane Mwaikambo <zwane@arm.linux.org.uk>
Cc: paulmck@us.ibm.com, sfr@canb.auug.org.au,
linux-kernel@vger.kernel.org, dipankar@in.ibm.com,
shaohua.li@intel.com, len.brown@intel.com
Subject: Re: [PATCH] Remove RCU abuse in cpu_idle()
Date: Sun, 12 Dec 2004 22:13:27 -0800 [thread overview]
Message-ID: <20041212221327.375fa4d0.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0412112244000.7847@montezuma.fsmlabs.com>
Zwane Mwaikambo <zwane@arm.linux.org.uk> wrote:
>
> On Sat, 11 Dec 2004, Zwane Mwaikambo wrote:
>
> > > Introduce cpu_idle_wait() on architectures requiring modification of
> > > pm_idle from modules, this will ensure that all processors have updated
> > > their cached values of pm_idle upon exit. This patch is to address the bug
> > > report at http://bugme.osdl.org/show_bug.cgi?id=1716 and replaces the
> > > current code fix which is in violation of normal RCU usage as pointed out
> > > by Stephen, Dipankar and Paul.
>
> ...
>
> void cpu_idle (void)
> {
> + int cpu = smp_processor_id();
> +
> /* endless idle loop with no priority at all */
This gives me scadzillions of "using smp_procesor_id() in preemptible"
warnings.
I'll shut that up with _smp_processor_id() but one does wonder what happens
if we get preempted and `cpu' refers to some other CPU?
next prev parent reply other threads:[~2004-12-13 6:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-05 0:45 Fw: [RFC] Strange code " Paul E. McKenney
2004-12-06 0:16 ` Stephen Rothwell
2004-12-06 6:46 ` Stephen Rothwell
2004-12-06 10:00 ` Zwane Mwaikambo
2004-12-06 7:20 ` Andrew Morton
2004-12-06 9:38 ` Zwane Mwaikambo
2004-12-06 16:04 ` Paul E. McKenney
2004-12-06 16:47 ` Zwane Mwaikambo
2004-12-06 19:22 ` Paul E. McKenney
2004-12-11 15:07 ` Zwane Mwaikambo
2004-12-12 4:54 ` [PATCH] Remove RCU abuse " Zwane Mwaikambo
2004-12-12 5:06 ` Zwane Mwaikambo
2004-12-12 5:49 ` Zwane Mwaikambo
2004-12-13 6:13 ` Andrew Morton [this message]
2004-12-13 6:22 ` Zwane Mwaikambo
2004-12-13 6:32 ` Andrew Morton
2004-12-13 7:09 ` Zwane Mwaikambo
2004-12-13 6:41 ` Andrew Morton
2004-12-13 7:13 ` Zwane Mwaikambo
2004-12-19 2:40 ` Nish Aravamudan
2004-12-20 0:59 ` Zwane Mwaikambo
2004-12-20 1:15 ` Nick Piggin
2004-12-20 1:44 ` Zwane Mwaikambo
2004-12-20 1:56 ` Nick Piggin
2004-12-20 2:10 ` Zwane Mwaikambo
2004-12-20 2:30 ` Nish Aravamudan
2004-12-20 18:27 ` Nishanth Aravamudan
2004-12-20 22:57 ` Zwane Mwaikambo
2004-12-20 23:15 ` Andrew Morton
2004-12-20 23:16 ` Zwane Mwaikambo
2004-12-20 23:26 ` Nishanth Aravamudan
2004-12-20 2:26 ` Nish Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041212221327.375fa4d0.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=dipankar@in.ibm.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@us.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=shaohua.li@intel.com \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome