mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Linus Torvalds <torvalds@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Question about memcpy_fromio prototype
Date: Tue, 14 Dec 2004 19:58:55 +0000	[thread overview]
Message-ID: <20041214195855.GU27199@parcelfarce.linux.theplanet.co.uk> (raw)


Hi Linus.  On x86 and ia64, memcpy_fromio is protoyped as:

static inline void memcpy_fromio(void *dst, volatile void __iomem *src, int count)

ALSA does this (except on x86 and sparc32, so you don't see it):

int copy_to_user_fromio(void __user *dst, const void __iomem *src, size_t count)
[...]
                memcpy_fromio(buf, src, c);

which provokes a warning from gcc that we're discarding a qualifier (the
'const') from src.  Is ALSA just wrong?  Or is the 'volatile' wrong?

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

             reply	other threads:[~2004-12-16 11:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-14 19:58 Matthew Wilcox [this message]
2004-12-14 20:15 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041214195855.GU27199@parcelfarce.linux.theplanet.co.uk \
    --to=matthew@wil.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®