From: Patrick Caulfield <patrick@tykepenguin.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Steve Whitehouse <SteveW@ACM.org>,
linux-decnet-user@lists.sourceforge.net, netdev@oss.sgi.com,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] net/decnet/: misc possible cleanups
Date: Wed, 15 Dec 2004 10:56:46 +0000 [thread overview]
Message-ID: <20041215105646.GB27420@tykepenguin.com> (raw)
In-Reply-To: <20041214125838.GC23151@stusta.de>
On Tue, Dec 14, 2004 at 01:58:38PM +0100, Adrian Bunk wrote:
> The patch below contains the following possible cleanups:
> - make needlessly global code static
> - dn_fib.c: remove the write-only global variable dn_fib_info_cnt
> - dn_fib.c: remove the unused global function dn_fib_rt_message
> - dn_neigh.c: remove the unused global function dn_neigh_pointopoint_notify
> - dn_timer.c: remove the fast timer code that isn't used
>
> Please review and comment on this patch.
>
Looks fine to me. I'm quite happy to lose the fast ack code - unused code is
only a confusion to those reading it IMHO. If we do the delayed-ack code in
future then it's easy enough to reinstate.
Thanks.
--
patrick
prev parent reply other threads:[~2004-12-15 10:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-14 12:58 Adrian Bunk
2004-12-14 13:32 ` Steven Whitehouse
2004-12-18 0:50 ` Adrian Bunk
2004-12-15 10:56 ` Patrick Caulfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041215105646.GB27420@tykepenguin.com \
--to=patrick@tykepenguin.com \
--cc=SteveW@ACM.org \
--cc=bunk@stusta.de \
--cc=linux-decnet-user@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®