From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262059AbULPWpE (ORCPT ); Thu, 16 Dec 2004 17:45:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262057AbULPWoz (ORCPT ); Thu, 16 Dec 2004 17:44:55 -0500 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:27352 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S262059AbULPWnF (ORCPT ); Thu, 16 Dec 2004 17:43:05 -0500 Date: Thu, 16 Dec 2004 22:43:05 +0000 From: Matthew Wilcox To: Pat Gefre Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org Subject: Re: [PATCH] 2.6.10 Altix : ioc4 serial driver support Message-ID: <20041216224304.GE7113@parcelfarce.linux.theplanet.co.uk> References: <200412162224.iBGMOQ52284713@fsgi900.americas.sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200412162224.iBGMOQ52284713@fsgi900.americas.sgi.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 16, 2004 at 04:24:26PM -0600, Pat Gefre wrote: > I have a serial driver for Altix I'd like to submit. Why put it in arch/ia64/sn/io/sn2/driver/ioc4_serial.c ?! drivers/serial/ioc4.c would be the right place for it. You put the Kconfig there -- that should be a clue. It seems like you're directly dereferencing pointers to io memory instead of calling readb and friends. I know, this driver doesn't need to be portable, but it helps any casual reader of this driver figure out what's going on. And you can get rid of the 'volatile' that way ;-) Linux Device Drivers, Second edition says you shouldn't use SA_INTERRUPT without good reason (http://www.xml.com/ldd/chapter/book/ch09.html#t3) -- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain