From: Francois Romieu <romieu@fr.zoreil.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.6.9-ac16
Date: Fri, 17 Dec 2004 19:54:03 +0100 [thread overview]
Message-ID: <20041217185403.GA4454@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <1103282619.4138.21.camel@laptopd505.fenrus.org>
Arjan van de Ven <arjan@infradead.org> :
> On Thu, 2004-12-16 at 18:43 +0000, Alan Cox wrote:
> > o Acenic must use __devinitdata for hotplug (Alan Cox)
> > | based on an RH patch
[...]
> MODULE_PARM_DESC(tx_ratio, "AceNIC/3C985/GA620 ratio of NIC memory used
> for TX/RX descriptors (range 0-63)");
>
>
> -static char version[] __initdata =
> +static char version[] __devinitdata =
> "acenic.c: v0.92 08/05/2002 Jes Sorensen, linux-acenic@SunSITE.dk\n"
> "http://home.cern.ch/~jes/gige/acenic.html\n";
>
> you broke this one... :-)
> the version var *cannot* be initdata of any kind, since the ethtool
> ioctl uses the variable. End Of Story(tm)
Episode 2
Actually ethtool_drvinfo.get_drvinfo() does not use _this_ version var
in the acenic driver. Btw it would be waaaaay too long for the 32 bytes
allowed in the misc fields of struct ethtool_drvinfo) (I messed the
r8169 driver this way).
--
Ueimor
next prev parent reply other threads:[~2004-12-17 18:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-16 18:43 Alan Cox
2004-12-17 11:23 ` Arjan van de Ven
2004-12-17 18:54 ` Francois Romieu [this message]
2004-12-17 13:08 ` Chris Ross
2004-12-17 14:51 ` Chris Friesen
2004-12-17 15:45 ` Chris Ross
2004-12-18 6:01 ` Thomas Gleixner
2004-12-18 15:11 ` Bill Davidsen
2004-12-18 15:06 ` Jan Engelhardt
2004-12-18 16:01 ` Chris Ross
2004-12-20 14:48 ` Alan Cox
2004-12-20 16:19 ` Chris Ross
2004-12-20 19:54 ` Alan Cox
2004-12-19 16:22 ` Thomas Gleixner
2004-12-17 23:35 Chuck Ebbert
2004-12-20 17:27 ` Chris Friesen
2004-12-21 9:11 Chuck Ebbert
2004-12-21 23:49 Chuck Ebbert
2004-12-21 23:58 ` Nick Piggin
2004-12-22 2:49 ` Con Kolivas
2004-12-22 6:44 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041217185403.GA4454@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®