mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philip R Auld <pauld@egenera.com>
To: torvalds@osdl.org, akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
Subject: [PATCH] Trivial - fix memory leak in free_percpu
Date: Fri, 17 Dec 2004 14:14:59 -0500	[thread overview]
Message-ID: <20041217191459.GD20026@vienna.egenera.com> (raw)

Hi,
	This fixes a memory leak where the percpu internal structure is 
not freed. Repeated add/remove device illustrates the leak nicely.

Please apply.

Thanks,

	Phil


Signed-off-by: Philip R. Auld <pauld@egenera.com>

diff -rupN linux-2.6.10-rc3-clean/mm/slab.c linux-2.6.10-rc3/mm/slab.c
--- linux-2.6.10-rc3-clean/mm/slab.c	2004-12-03 16:55:13.000000000 -0500
+++ linux-2.6.10-rc3/mm/slab.c	2004-12-17 11:08:45.377108680 -0500
@@ -2573,6 +2573,7 @@ free_percpu(const void *objp)
 			continue;
 		kfree(p->ptrs[i]);
 	}
+	kfree(p);
 }
 
 EXPORT_SYMBOL(free_percpu);


                 reply	other threads:[~2004-12-17 19:15 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041217191459.GD20026@vienna.egenera.com \
    --to=pauld@egenera.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=trivial@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®