From: Matthew Wilcox <matthew@wil.cx>
To: James Nelson <james4765@verizon.net>
Cc: kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org,
akpm@osdl.org
Subject: Re: [KJ] [PATCH] generic_serial: replace cli()/sti() with spin_lock_irqsave()/spin_unlock_irqrestore()
Date: Sat, 18 Dec 2004 03:02:33 +0000 [thread overview]
Message-ID: <20041218030233.GV7113@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20041218002600.19176.34205.85406@localhost.localdomain>
On Fri, Dec 17, 2004 at 06:25:39PM -0600, James Nelson wrote:
>
> +static spinlock_t driver_lock = SPIN_LOCK_UNLOCKED;
> +
It can't be static. The drivers are going to have to use it in their
interrupt routines to synchronise with the generic_serial code.
It'd be much better to convert the drivers that use generic_serial
to use serial_core instead. I'd recommend not touching this unless you
have the hardware concerned.
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
prev parent reply other threads:[~2004-12-18 3:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-18 0:25 James Nelson
2004-12-18 3:02 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041218030233.GV7113@parcelfarce.linux.theplanet.co.uk \
--to=matthew@wil.cx \
--cc=akpm@osdl.org \
--cc=james4765@verizon.net \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome