From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: roland@topspin.com
Cc: linux-kernel@vger.kernel.org, openib-general@openib.org,
netdev@oss.sgi.com, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH][v4][19/24] Add IPoIB (IP-over-InfiniBand) driver
Date: Mon, 20 Dec 2004 15:58:36 +0900 (JST) [thread overview]
Message-ID: <20041220.155836.75677852.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <200412192215.fZX1ZQqQD4QGkKcF@topspin.com>
In article <200412192215.fZX1ZQqQD4QGkKcF@topspin.com> (at Sun, 19 Dec 2004 22:15:14 -0800), Roland Dreier <roland@topspin.com> says:
> +enum {
> + IPOIB_PACKET_SIZE = 2048,
> + IPOIB_BUF_SIZE = IPOIB_PACKET_SIZE + IB_GRH_BYTES,
> +
> + IPOIB_ENCAP_LEN = 4,
> +
> + IPOIB_RX_RING_SIZE = 128,
> + IPOIB_TX_RING_SIZE = 64,
> +
> + IPOIB_NUM_WC = 4,
> +
> + IPOIB_MAX_PATH_REC_QUEUE = 3,
> + IPOIB_MAX_MCAST_QUEUE = 3,
above entries does not seem to appropriate for enum (than #define).
> +
> + IPOIB_FLAG_OPER_UP = 0,
> + IPOIB_FLAG_ADMIN_UP = 1,
> + IPOIB_PKEY_ASSIGNED = 2,
> + IPOIB_PKEY_STOP = 3,
> + IPOIB_FLAG_SUBINTERFACE = 4,
> + IPOIB_MCAST_RUN = 5,
> + IPOIB_STOP_REAPER = 6,
this seems ok, but are "xxx_FLAG_xxx" entries really flags?
> + IPOIB_MAX_BACKOFF_SECONDS = 16,
ditto, w/ first one.
> + IPOIB_MCAST_FLAG_FOUND = 0, /* used in set_multicast_list */
> + IPOIB_MCAST_FLAG_SENDONLY = 1,
> + IPOIB_MCAST_FLAG_BUSY = 2, /* joining or already joined */
> + IPOIB_MCAST_FLAG_ATTACHED = 3,
seems fine, but are these really flags?
--yoshfuji
next prev parent reply other threads:[~2004-12-20 8:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-20 6:14 [PATCH][v4][0/24] Second InfiniBand merge candidate patch set Roland Dreier
2004-12-20 6:14 ` [PATCH][v4][1/24] Add core InfiniBand support (public headers) Roland Dreier
2004-12-20 6:14 ` [PATCH][v4][2/24] Add core InfiniBand support Roland Dreier
2004-12-20 6:14 ` [PATCH][v4][3/24] Hook up drivers/infiniband Roland Dreier
2004-12-20 6:14 ` [PATCH][v4][4/24] Add InfiniBand MAD (management datagram) support (public headers) Roland Dreier
2004-12-20 6:14 ` [PATCH][v4][5/24] Add InfiniBand MAD (management datagram) support Roland Dreier
2004-12-20 6:14 ` [PATCH][v4][6/24] Add InfiniBand MAD (management datagram) support (private headers) Roland Dreier
2004-12-20 6:14 ` [PATCH][v4][7/24] Add InfiniBand MAD SMI support Roland Dreier
2004-12-20 6:14 ` [PATCH][v4][8/24] Add InfiniBand SA (Subnet Administration) query support Roland Dreier
2004-12-20 6:14 ` [PATCH][v4][9/24] Add Mellanox HCA low-level driver Roland Dreier
2004-12-20 6:15 ` [PATCH][v4][10/24] Add Mellanox HCA low-level driver (midlayer interface) Roland Dreier
2004-12-20 6:15 ` [PATCH][v4][11/24] Add Mellanox HCA low-level driver (FW commands) Roland Dreier
2004-12-20 6:15 ` [PATCH][v4][12/24] Add Mellanox HCA low-level driver (EQ) Roland Dreier
2004-12-20 6:15 ` [PATCH][v4][13/24] Add Mellanox HCA low-level driver (initialization) Roland Dreier
2004-12-20 6:15 ` [PATCH][v4][14/24] Add Mellanox HCA low-level driver (QP/CQ) Roland Dreier
2004-12-20 6:15 ` [PATCH][v4][15/24] Add Mellanox HCA low-level driver (last bits) Roland Dreier
2004-12-20 6:15 ` [PATCH][v4][16/24] Add Mellanox HCA low-level driver (MAD) Roland Dreier
2004-12-20 6:15 ` [PATCH][v4][17/24] IPoIB IPv4 multicast Roland Dreier
2004-12-20 6:15 ` [PATCH][v4][18/24] IPoIB IPv6 support Roland Dreier
2004-12-20 6:15 ` [PATCH][v4][19/24] Add IPoIB (IP-over-InfiniBand) driver Roland Dreier
2004-12-20 6:15 ` [PATCH][v4][20/24] Add IPoIB multicast & partition code Roland Dreier
2004-12-20 6:15 ` [PATCH][v4][21/24] Add InfiniBand userspace MAD support Roland Dreier
2004-12-20 6:15 ` [PATCH][v4][22/24] Document InfiniBand ioctl use Roland Dreier
2004-12-20 6:15 ` [PATCH][v4][23/24] Add InfiniBand Documentation files Roland Dreier
2004-12-20 6:15 ` [PATCH][v4][24/24] InfiniBand MAINTAINERS entry Roland Dreier
2004-12-20 6:58 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
2004-12-20 16:45 ` [PATCH][v4][19/24] Add IPoIB (IP-over-InfiniBand) driver Roland Dreier
[not found] ` <200412201314.35502.arnd@arndb.de>
[not found] ` <20041220.221709.99112884.yoshfuji@linux-ipv6.org>
2004-12-20 16:10 ` Arnd Bergmann
2004-12-20 6:38 ` [PATCH][v4][0/24] Second InfiniBand merge candidate patch set YOSHIFUJI Hideaki / 吉藤英明
2004-12-28 5:00 ` David S. Miller
2004-12-28 5:19 ` Roland Dreier
2004-12-28 5:26 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041220.155836.75677852.yoshfuji@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=openib-general@openib.org \
--cc=roland@topspin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®