From: Andrew Morton <akpm@osdl.org>
To: Rik van Riel <riel@redhat.com>
Cc: linux-kernel@vger.kernel.org, Robert_Hentosh@Dell.com
Subject: Re: [PATCH][1/2] adjust dirty threshold for lowmem-only mappings
Date: Mon, 20 Dec 2004 12:54:43 -0800 [thread overview]
Message-ID: <20041220125443.091a911b.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0412201013080.13935@chimarrao.boston.redhat.com>
Rik van Riel <riel@redhat.com> wrote:
>
> Simply running "dd if=/dev/zero of=/dev/hd<one you can miss>" will
> result in OOM kills, with the dirty pagecache completely filling up
> lowmem.
That surely used to work - I have a feeling that it got broken somehow.
The below might fix it, but probably not.
The intended behaviour is that the page-allocating process will throttle
and will then pick up those pages from the tail of the LRU which
rotate_reclaimable_page() put there.
We haven't been incrementing local variable total_scanned since the
scan_control stuff went in. That broke kswapd throttling.
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
25-akpm/mm/vmscan.c | 1 +
1 files changed, 1 insertion(+)
diff -puN mm/vmscan.c~vmscan-total_scanned-fix mm/vmscan.c
--- 25/mm/vmscan.c~vmscan-total_scanned-fix 2004-12-20 12:47:25.855643408 -0800
+++ 25-akpm/mm/vmscan.c 2004-12-20 12:47:25.860642648 -0800
@@ -1063,6 +1063,7 @@ scan:
shrink_slab(sc.nr_scanned, GFP_KERNEL, lru_pages);
sc.nr_reclaimed += reclaim_state->reclaimed_slab;
total_reclaimed += sc.nr_reclaimed;
+ total_scanned += sc.nr_scanned;
if (zone->all_unreclaimable)
continue;
if (zone->pages_scanned >= (zone->nr_active +
_
next prev parent reply other threads:[~2004-12-20 20:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-20 15:15 Rik van Riel
2004-12-20 15:23 ` Rik van Riel
2004-12-20 20:54 ` Andrew Morton [this message]
2004-12-20 21:27 ` Rik van Riel
2004-12-23 19:21 ` Rik van Riel
2004-12-24 16:01 ` Andrea Arcangeli
2004-12-24 16:22 ` Rik van Riel
2004-12-24 16:40 ` Andrea Arcangeli
2004-12-24 22:12 ` Rik van Riel
2004-12-25 2:07 ` Andrea Arcangeli
2004-12-25 17:59 ` Rik van Riel
2004-12-25 18:36 ` Andrea Arcangeli
2004-12-25 19:07 ` William Lee Irwin III
2004-12-25 20:03 ` Andrea Arcangeli
2004-12-26 3:07 ` William Lee Irwin III
2005-01-02 16:10 ` Andrea Arcangeli
2005-01-02 16:36 ` William Lee Irwin III
2005-01-02 16:53 ` Rik van Riel
2005-01-02 17:21 ` Andrea Arcangeli
2004-12-25 22:03 ` Nikita Danilov
2004-12-26 3:16 ` William Lee Irwin III
2005-01-02 15:11 ` Jens Axboe
2005-01-02 16:18 ` Andrea Arcangeli
2005-01-02 20:03 ` Andrew Morton
2005-01-02 20:25 ` William Lee Irwin III
2004-12-20 16:46 Robert_Hentosh
2004-12-20 17:56 ` Sami Farin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041220125443.091a911b.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=Robert_Hentosh@Dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome