On Tuesday, December 14, 2004 2:20 pm, Jesse Barnes wrote:
> On Tuesday, December 14, 2004 1:45 pm, Jon Smirl wrote:
> > These drivers should be using the new ROM API in the PCI driver
> > instead of manipulating the ROMs directly. Now that the ROM API is in
> > the kernel all direct use of PCI_ENABLE_ROM should be removed. There
> > are about thirty places in the kernel doing direct access. Kernel
> > janitors would probably be a good place to track removing
> > PCI_ENABLE_ROM.
>
> Sure... but in the meantime the drivers should probably be trivially fixed
> like this so things don't break.

Oops, didn't realize that changing them to use pci_rom_enable/disable would be 
just as trivial as my fix.  Tested on sn2.

This patch fixes a few errors in the aty fb drivers by making them use 
pci_rom_enable/disable instead of manipulating BARs directly.  They were both 
a) incorrectly programming resource values into the BARs instead of actual 
BAR values (resources are cookies and shouldn't be used that way), and b) 
they were both clobbering the original value of the BAR corresponding to 
their ROM, also a no-no.  Switching to pci_rom_enable/disable fixes both at 
once and kills some code.

Signed-off-by: Jesse Barnes <jbarnes@sgi.com>

Thanks,
Jesse