From: Chuck Ebbert <76306.1226@compuserve.com>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
William Lee Irwin III <wli@holomorphy.com>,
Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua>
Subject: Re: 2.6.x BUGs at boot time (APIC related)
Date: Thu, 23 Dec 2004 11:59:47 -0500 [thread overview]
Message-ID: <200412231203_MC3-1-919F-4F48@compuserve.com> (raw)
vda wrote:
> --- linux-2.6.10-rc3.src/arch/i386/kernel/apic.c.old Mon Dec 20 14:13:59 2004
> +++ linux-2.6.10-rc3.src/arch/i386/kernel/apic.c Thu Dec 23 08:54:13 2004
> @@ -1250,8 +1250,10 @@
> */
> int __init APIC_init_uniprocessor (void)
> {
> - if (enable_local_apic < 0)
> + if (enable_local_apic < 0) {
> clear_bit(X86_FEATURE_APIC, boot_cpu_data.x86_capability);
> + return -1;
> + }
>
> if (!smp_found_config && !cpu_has_apic)
> return -1;
Mikael Pettersson wrote:
> The early return just hides the real bug, whatever it is.
How about this:
- if (!smp_found_config && !cpu_has_apic)
+ if (!smp_found_config || !cpu_has_apic)
--
Please take it as a sign of my infinite respect for you,
that I insist on you doing all the work.
-- Rusty Russell
next reply other threads:[~2004-12-23 17:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-23 16:59 Chuck Ebbert [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-12-23 16:11 Mikael Pettersson
2004-12-23 16:22 ` William Lee Irwin III
2004-12-22 17:31 Denis Vlasenko
2004-12-23 11:02 ` Denis Vlasenko
2004-12-23 9:12 ` William Lee Irwin III
2004-12-23 14:57 ` Denis Vlasenko
2004-12-23 9:33 ` Arnaud Patard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200412231203_MC3-1-919F-4F48@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@csd.uu.se \
--cc=mingo@redhat.com \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome