From: Pavel Machek <pavel@ucw.cz>
To: Karel Kulhavy <clock@twibright.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Twibright I2C2P driver
Date: Mon, 27 Dec 2004 16:06:18 +0100 [thread overview]
Message-ID: <20041227150618.GG1043@openzaurus.ucw.cz> (raw)
In-Reply-To: <20041227131840.GC3045@beton.cybernet.src>
Hi!
> I have just published Twibright I2C2P:
>
> * I2C interface (adaptor) for parallel port
> * Free technology electronics device
> * Bidirectional: Both SDA and SCL are bidirectional
> * Optically isolated
> * Powered from parallel port
> * Driver for Linux kernel
Its quite short. Did you forget to attach actual c source? Or is it
this simple?
> @@ -140,7 +141,11 @@
> .getscl = parport_getscl,
> .udelay = 60,
> .mdelay = 60,
> - .timeout = HZ,
> + .timeout = (HZ+99)/100,
> + /* This is 10ms. Parport adapter of type 6 may be
> + * powered down which introduces 90sec delay to
> + * machine boot. I consider 10ms to be sufficient for
90msec?
> + * the parport adapter timeout. --Clock */
Avoid signing comments like this. Neccessary info is
in bitkeeper logs anyway.
> @@ -38,6 +38,9 @@
> struct lineop getsda;
> struct lineop getscl;
> struct lineop init;
> + struct lineop init2; /* Added by Clock */
and this.
Pavel
--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms
next prev parent reply other threads:[~2004-12-27 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-27 13:18 Karel Kulhavy
2004-12-27 15:06 ` Pavel Machek [this message]
[not found] ` <20041227155621.GC4626@beton.cybernet.src>
2004-12-27 20:09 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041227150618.GG1043@openzaurus.ucw.cz \
--to=pavel@ucw.cz \
--cc=clock@twibright.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome