From: Bernard Blackham <bernard@blackham.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: mingo@elte.hu, ncunningham@linuxmail.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched-fix-scheduling-latencies-in-mttrc reenables interrupts
Date: Mon, 27 Dec 2004 23:20:37 +0800 [thread overview]
Message-ID: <20041227152037.GA4646@blackham.com.au> (raw)
In-Reply-To: <20041227013653.67965d46.akpm@osdl.org>
On Mon, Dec 27, 2004 at 01:36:53AM -0800, Andrew Morton wrote:
> Not OK. That global `sal_flags' is not protected by the spinlock
> because spin_lock_irqsave() saves the flags before taking the
> lock.
Ahh, d'oh.
> How about this?
>
> diff -puN arch/i386/kernel/cpu/mtrr/generic.c~sched-fix-scheduling-latencies-in-mttrc-reenables-interrupts arch/i386/kernel/cpu/mtrr/generic.c
Won't object here.
Thanks,
Bernard.
--
Bernard Blackham <bernard at blackham dot com dot au>
prev parent reply other threads:[~2004-12-27 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-27 6:28 Bernard Blackham
2004-12-27 9:36 ` Andrew Morton
2004-12-27 15:20 ` Bernard Blackham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041227152037.GA4646@blackham.com.au \
--to=bernard@blackham.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=ncunningham@linuxmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome