mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Georg Prenner <georg.prenner@aon.at>, linux-kernel@vger.kernel.org
Subject: Re: make errors (make clean, make menuconfig) make -C /usr/src/linux-2.6.10 O=/usr/src/linux-2.6.10 menuconfig
Date: Wed, 29 Dec 2004 00:23:06 +0100	[thread overview]
Message-ID: <20041228232306.GA29461@mars.ravnborg.org> (raw)
In-Reply-To: <20041227231934.GA9251@mars.ravnborg.org>

On Tue, Dec 28, 2004 at 12:19:34AM +0100, Sam Ravnborg wrote:
> ...
> 
> It is the following code snippet that causes the troubles:
> ---
> outputmakefile:
>         $(Q)if /usr/bin/env test ! $(srctree) -ef $(objtree); then \
>         $(CONFIG_SHELL) $(srctree)/scripts/mkmakefile
> ---

env was behaving different in some setups - and located in other places.
Since I cannot remeber why it is there I the fix was simple - remove it.

	Sam

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/12/28 19:12:15+01:00 sam@mars.ravnborg.org 
#   kbuild: drop use of /usr/bin/env in top-level Makefile
#   
#   The use of env is not needed, and caused the output makefile to be
#   created in some setups where it was not supposed to.
#   Seems to be an issue with GNU sh-utils version of env.
#   
#   One user also reported env to be located in another place (/usr/local/bin/..).
#   This patch fixes bug: http://bugme.osdl.org/show_bug.cgi?id=3953
#   
#   Thanks to "Mark Williams (MWP)" <mwp@internode.on.net> for helping tracking this down.
#   
#   Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
# 
# Makefile
#   2004/12/28 19:11:36+01:00 sam@mars.ravnborg.org +1 -1
#   Drop usage of /usr/bin/env
# 
diff -Nru a/Makefile b/Makefile
--- a/Makefile	2004-12-29 00:20:21 +01:00
+++ b/Makefile	2004-12-29 00:20:21 +01:00
@@ -389,7 +389,7 @@
 # using a seperate output directory. This allows convinient use
 # of make in output directory
 outputmakefile:
-	$(Q)if /usr/bin/env test ! $(srctree) -ef $(objtree); then \
+	$(Q)if test ! $(srctree) -ef $(objtree); then \
 	$(CONFIG_SHELL) $(srctree)/scripts/mkmakefile              \
 	    $(srctree) $(objtree) $(VERSION) $(PATCHLEVEL)         \
 	    > $(objtree)/Makefile;                                 \

      reply	other threads:[~2004-12-28 23:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-27 21:53 Georg Prenner
2004-12-27 22:48 ` Sam Ravnborg
2004-12-27 23:19   ` Sam Ravnborg
2004-12-28 23:23     ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041228232306.GA29461@mars.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=georg.prenner@aon.at \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®