From: Christoph Hellwig <hch@infradead.org>
To: Jonathan Ho <jonathanho15@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: kernel lib parser: cleaned up code and fixed redundancies
Date: Wed, 29 Dec 2004 07:36:00 +0000 [thread overview]
Message-ID: <20041229073600.GA10453@infradead.org> (raw)
In-Reply-To: <41D1FD25.3020403@gmail.com>
> - for (p = table; !match_one(s, p->pattern, args) ; p++)
> - ;
> + for (p = table; !match_one(s, p->pattern, args); p++);
this is a regression in readability. Also your patch is
whitespace-damaged.
prev parent reply other threads:[~2004-12-29 8:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-29 0:41 Jonathan Ho
2004-12-29 1:03 ` Jesper Juhl
2004-12-29 7:36 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041229073600.GA10453@infradead.org \
--to=hch@infradead.org \
--cc=jonathanho15@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®