From: Andries Brouwer <aebr@win.tue.nl>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andries Brouwer <aebr@win.tue.nl>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
torvalds@osdl.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: PATCH: 2.6.10 - Still mishandles volumes without geometry data
Date: Wed, 29 Dec 2004 20:28:52 +0100 [thread overview]
Message-ID: <20041229192852.GC2818@pclin040.win.tue.nl> (raw)
In-Reply-To: <1104330967.30080.12.camel@localhost.localdomain>
On Wed, Dec 29, 2004 at 02:36:11PM +0000, Alan Cox wrote:
> > > - printk(", CHS=%d/%d/%d",
> > > - drive->bios_cyl, drive->bios_head, drive->bios_sect);
> > > + if(drive->bios_cyl)
> > > + printk(", CHS=%d/%d/%d",
> > > + drive->bios_cyl, drive->bios_head, drive->bios_sect);
> >
> > Reasonable. (But s/if(/if (/ .)
> > On the other hand, I like the "CHS=0/0/0" - it makes very clear what is wrong
> > in case lilo or so has geometry problems.
>
> 0/0/0 is valid in these cases - would it be better if it printed
> something else instead for that situation ("No physical geometry, ")
> perhaps ?
But it is not the "physical geometry" (whatever that may be) that is printed.
Not drive->head but drive->bios_head. It is easiest just to leave it.
Andries
prev parent reply other threads:[~2004-12-29 19:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-27 13:57 Alan Cox
2004-12-28 20:48 ` Bartlomiej Zolnierkiewicz
2004-12-28 22:03 ` Alan Cox
2004-12-28 22:08 ` Alan Cox
2004-12-29 2:52 ` Andries Brouwer
2004-12-29 14:36 ` Alan Cox
2004-12-29 19:28 ` Andries Brouwer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041229192852.GC2818@pclin040.win.tue.nl \
--to=aebr@win.tue.nl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®