From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261842AbULaJtX (ORCPT ); Fri, 31 Dec 2004 04:49:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261833AbULaJtX (ORCPT ); Fri, 31 Dec 2004 04:49:23 -0500 Received: from fw.osdl.org ([65.172.181.6]:26049 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S261832AbULaJtP (ORCPT ); Fri, 31 Dec 2004 04:49:15 -0500 Date: Fri, 31 Dec 2004 01:49:05 -0800 From: Andrew Morton To: William Park Cc: juhl-lkml@dif.dk, marcelo.tosatti@cyclades.com, linux-kernel@vger.kernel.org Subject: Re: waiting 10s before mounting root filesystem? Message-Id: <20041231014905.30b05a11.akpm@osdl.org> In-Reply-To: <20041231035834.GA2421@node1.opengeometry.net> References: <20041227195645.GA2282@node1.opengeometry.net> <20041227201015.GB18911@sweep.bur.st> <41D07D56.7020702@netshadow.at> <20041229005922.GA2520@node1.opengeometry.net> <20041230152531.GB5058@logos.cnet> <20041231035834.GA2421@node1.opengeometry.net> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org William Park wrote: > > - printk("VFS: Cannot open root device \"%s\" or %s\n", > - root_device_name, b); > - printk("Please append a correct \"root=\" boot option\n"); > + if (--tryagain) { > + printk (KERN_WARNING "VFS: Waiting %dsec for root device...\n", tryagain); > + ssleep (1); > + goto retry; > + } > + printk (KERN_CRIT "VFS: Cannot open root device \"%s\" or %s\n", root_device_name, b); > + printk (KERN_CRIT "Please append a correct \"root=\" boot option\n"); Why is this patch needed? If it is to offer the user a chance to insert the correct medium or to connect the correct device, why not rely upon the user doing that thing and then hitting reset?