From: Matthew Wilcox <matthew@wil.cx>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
ZP Gu <zpg@castle.net>
Subject: Re: [PATCH][RFC] clean out old cruft from FD MCS driver
Date: Tue, 4 Jan 2005 03:07:17 +0000 [thread overview]
Message-ID: <20050104030717.GQ18080@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <Pine.LNX.4.61.0501032350040.3529@dragon.hygekrogen.localhost>
On Tue, Jan 04, 2005 at 12:11:27AM +0100, Jesper Juhl wrote:
> At this point I got the feeling that this driver had been left to rot and
> I desided to see if there was more cruft in there that we might as well
> get rid of, and indeed there is.
Yup. There's a lot of cruft in that driver. I really don't like the
look of fd_mcs_intr() -- trying to deduce whether or not there's a data phase
out based on the command byte? urgh.
There's a somehat better-maintained driver -- fdomain.c. It'd be great
if someone could make fdomain.c support the MCA cards -- and even the PCMCIA
cards without having the separate fdomain_stub.c. I'd be happy to make
suggestions to anyone who has an fdomain card and wants to take on the
responsibility of maintaining the driver.
If anyone's really keen, there's an ISA card on eBay for $2 ...
http://cgi.ebay.com/ws/eBayISAPI.dll?ViewItem&item=5152656129
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
next prev parent reply other threads:[~2005-01-04 3:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-03 23:11 Jesper Juhl
2005-01-04 3:07 ` Matthew Wilcox [this message]
2005-01-05 23:18 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050104030717.GQ18080@parcelfarce.linux.theplanet.co.uk \
--to=matthew@wil.cx \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=zpg@castle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®