mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: Andries Brouwer <Andries.Brouwer@cwi.nl>
Cc: Nikita Danilov <nikita@clusterfs.com>,
	torvalds@osdl.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] remove duplicated patch fragment
Date: Tue, 4 Jan 2005 14:35:10 -0800	[thread overview]
Message-ID: <20050104143510.G469@build.pdx.osdl.net> (raw)
In-Reply-To: <20050104172614.GB12861@apps.cwi.nl>; from Andries.Brouwer@cwi.nl on Tue, Jan 04, 2005 at 06:26:14PM +0100

* Andries Brouwer (Andries.Brouwer@cwi.nl) wrote:
> On Tue, Jan 04, 2005 at 03:36:11PM +0300, Nikita Danilov wrote:
> > On another account, shouldn't capable(CAP_SYS_ADMIN) checks in
> > cap_vm_enough_memory() be replaced with capable(CAP_SYS_RESOURCE):
> > (CAP_SYS_RESOURCE is used by file systems to control reserved disk
> > blocks)?
> 
> The use of current->euid comes from the use of current->euid in dummy.c
> a few lines higher up in the same routine.
> The use of CAP_SYS_ADMIN comes from the use of CAP_SYS_ADMIN in
> commoncap.c a few lines higher up in the same routine.
> 
> I have no strong opinion about what is best.

Unfortunately, this what committed on 2003/05/25 (IOW, it's been in
there since 2.5.70).  So, we can't really change that w/out possibly
breaking things.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

  parent reply	other threads:[~2005-01-04 22:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200501040611.j046BHoq005158@hera.kernel.org>
2005-01-04 12:36 ` [PATCH] mm: overcommit updates Nikita Danilov
2005-01-04 17:26   ` [PATCH] remove duplicated patch fragment Andries Brouwer
2005-01-04 22:21     ` Chris Wright
2005-01-04 22:35     ` Chris Wright [this message]
2005-01-04 22:03   ` [PATCH] mm: overcommit updates Alan Cox
2005-01-04 23:38     ` Andries Brouwer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050104143510.G469@build.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=Andries.Brouwer@cwi.nl \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikita@clusterfs.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome