From: Vincent Hanquez <tab@snarc.org>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH][4/4] let's kill verify_area - convert kernel/printk.c to access_ok()
Date: Fri, 7 Jan 2005 13:51:40 +0100 [thread overview]
Message-ID: <20050107125140.GA2774@snarc.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0501070207460.3430@dragon.hygekrogen.localhost>
On Fri, Jan 07, 2005 at 02:18:55AM +0100, Jesper Juhl wrote:
> @@ -300,8 +300,8 @@ int do_syslog(int type, char __user * bu
> error = 0;
> if (!len)
> goto out;
> - error = verify_area(VERIFY_WRITE,buf,len);
> - if (error)
> + error = access_ok(VERIFY_WRITE,buf,len);
> + if (!error)
I would rather put the ! on access_ok
"if (!error)" is read as "if no error"
--
Vincent Hanquez
next prev parent reply other threads:[~2005-01-07 12:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-07 1:18 Jesper Juhl
2005-01-07 12:51 ` Vincent Hanquez [this message]
2005-01-07 15:38 Peter Kjellerstedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050107125140.GA2774@snarc.org \
--to=tab@snarc.org \
--cc=akpm@osdl.org \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome