From: Shaheed <srhaque@iee.org>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] support for gzipped (ELF) core dumps
Date: Sat, 8 Jan 2005 17:27:52 +0000 [thread overview]
Message-ID: <200501081727.52637.srhaque@iee.org> (raw)
>+/* This table is needed for efficient CRC32 calculation */
>+static const unsigned long crc_table[8][256] = {
>+ {
>+ 0x00000000UL, 0x77073096UL, 0xee0e612cUL, 0x990951baUL, 0x076dc419UL,
First, by using "unsigned long", you may be doubling the size on most 64 bit
platforms. Second, I'm pretty sure there is a standard implementation of
several CRCs already in the kernel - is there a reason not to use one of them
(e.g. a different polynomial)?
next reply other threads:[~2005-01-08 17:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-08 17:27 Shaheed [this message]
2005-01-13 11:51 ` Jan Frey
2005-01-13 13:29 ` Shaheed
2005-01-13 15:28 ` [PATCH] Updated: " Jan Frey
-- strict thread matches above, loose matches on Subject: below --
2005-01-06 13:19 [PATCH] " Jan Frey
2005-01-06 13:30 ` linux-os
2005-01-06 13:43 ` Miquel van Smoorenburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501081727.52637.srhaque@iee.org \
--to=srhaque@iee.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome