From: domen@coderock.org
To: axboe@suse.de
Cc: linux-kernel@vger.kernel.org, domen@coderock.org, nacc@us.ibm.com
Subject: [patch 1/1] ide/ide-cd: use ssleep() instead of schedule_timeout()
Date: Wed, 12 Jan 2005 00:17:00 +0100 [thread overview]
Message-ID: <20050111231701.1A9B31F225@trashy.coderock.org> (raw)
Description: Uses ssleep() in place of cdrom_sleep() to guarantee the task
delays as expected. Remove cdrom_sleep() definition, as this is the only place
where it is called.
Signed-off-by: Nishanth Aravamudan
Acked-by: Jens Axboe <axboe@suse.de>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/drivers/ide/ide-cd.c | 15 +--------------
1 files changed, 1 insertion(+), 14 deletions(-)
diff -puN drivers/ide/ide-cd.c~msleep-drivers_ide_ide-cd drivers/ide/ide-cd.c
--- kj/drivers/ide/ide-cd.c~msleep-drivers_ide_ide-cd 2005-01-10 18:00:53.000000000 +0100
+++ kj-domen/drivers/ide/ide-cd.c 2005-01-10 18:00:53.000000000 +0100
@@ -1464,19 +1464,6 @@ static ide_startstop_t cdrom_do_packet_c
}
-/* Sleep for TIME jiffies.
- Not to be called from an interrupt handler. */
-static
-void cdrom_sleep (int time)
-{
- int sleep = time;
-
- do {
- set_current_state(TASK_INTERRUPTIBLE);
- sleep = schedule_timeout(sleep);
- } while (sleep);
-}
-
static
int cdrom_queue_packet_command(ide_drive_t *drive, struct request *rq)
{
@@ -1511,7 +1498,7 @@ int cdrom_queue_packet_command(ide_drive
/* The drive is in the process of loading
a disk. Retry, but wait a little to give
the drive time to complete the load. */
- cdrom_sleep(2 * HZ);
+ ssleep(2);
} else {
/* Otherwise, don't retry. */
retries = 0;
_
reply other threads:[~2005-01-11 23:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050111231701.1A9B31F225@trashy.coderock.org \
--to=domen@coderock.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nacc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome