From: Andrew Morton <akpm@osdl.org>
To: tglx@linutronix.de
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.10-mm2 Resend] Fix preemption race [1/3] (Core/i386)
Date: Wed, 12 Jan 2005 16:05:49 -0800 [thread overview]
Message-ID: <20050112160549.07e07a78.akpm@osdl.org> (raw)
In-Reply-To: <20050112124910.1.patchmail@tglx>
tglx@linutronix.de wrote:
>
> --- 2.6.10-mm2/arch/i386/kernel/entry.S (revision 148)
> +++ 2.6.10-mm2/arch/i386/kernel/entry.S (working copy)
> @@ -189,6 +189,7 @@
>
> #ifdef CONFIG_PREEMPT
> ENTRY(resume_kernel)
> + cli
> cmpl $0,TI_preempt_count(%ebp) # non-zero preempt_count ?
> jnz restore_all
> need_resched:
> @@ -197,10 +198,7 @@
> jz restore_all
> testl $IF_MASK,EFLAGS(%esp) # interrupts off (exception path) ?
> jz restore_all
> - sti
> - call preempt_schedule
> - cli
> - movl $0,TI_preempt_count(%ebp)
> + call preempt_schedule_irq();
whee, who needs a C compiler anyway? Did that actually assemble?
I'll fix that one up ;)
prev parent reply other threads:[~2005-01-13 0:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-12 11:49 tglx
2005-01-12 11:57 ` [PATCH 2.6.10-mm2 Resend] Make use of preempt_schedule_irq [2/3] (PPC) Thomas Gleixner
2005-01-12 12:08 ` [PATCH 2.6.10-mm2 Resend] Make use of preempt_schedule_irq [3/3] (ARM) Thomas Gleixner
2005-01-13 0:05 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050112160549.07e07a78.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome