From: Christian Borntraeger <cborntra@de.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Arjan van de Ven <arjan@infradead.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] reintroduce EXPORT_SYMBOL(task_nice) for binfmt_elf32
Date: Thu, 13 Jan 2005 23:29:12 +0100 [thread overview]
Message-ID: <200501132329.13881.cborntra@de.ibm.com> (raw)
In-Reply-To: <20050113210501.GA29232@infradead.org>
Christoph Hellwig wrote:
> Although a little comment explaining what it's exported for might be
> nice ;-) So people can't complain if it's unexported if binfmt_elf
> doesn't need it anymore one day.
OK. I dont mind if you apply this patch or the former one without the
comment. Whatever you prefer.
Signed-off-by: Christian Borntraeger <cborntra@de.ibm.com>
--- a/kernel/sched.c 2005-01-12 01:42:35 +01:00
+++ b/kernel/sched.c 2005-01-13 23:21:01 +01:00
@@ -3187,6 +3187,15 @@
return TASK_NICE(p);
}
+/*
+ * The only users of task_nice are binfmt_elf and binfmt_elf32.
+ * binfmt_elf is no longer modular, but binfmt_elf32 still is.
+ * Therefore, task_nice is needed if there is a compat_mode.
+ */
+#ifdef CONFIG_COMPAT
+EXPORT_SYMBOL(task_nice);
+#endif
+
/**
* idle_cpu - is a given cpu idle currently?
* @cpu: the processor in question.
prev parent reply other threads:[~2005-01-13 22:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-13 19:42 Christian Borntraeger
2005-01-13 19:48 ` Christoph Hellwig
2005-01-13 21:02 ` Christian Borntraeger
2005-01-13 21:05 ` Christoph Hellwig
2005-01-13 22:29 ` Christian Borntraeger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501132329.13881.cborntra@de.ibm.com \
--to=cborntra@de.ibm.com \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome