mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Karim Yaghmour <karim@opersys.com>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	LTT-Dev <ltt-dev@shafik.org>
Subject: Re: [PATCH 4/8 ] ltt for 2.6.10 : fs/ events
Date: Fri, 14 Jan 2005 21:49:57 +0100	[thread overview]
Message-ID: <20050114204957.GB8385@mars.ravnborg.org> (raw)
In-Reply-To: <41E76288.2080004@opersys.com>

Hi Karim.

>  void __wait_on_buffer(struct buffer_head * bh)
>  {
> +	ltt_ev_file_system(LTT_EV_FILE_SYSTEM_BUF_WAIT_START, 0, 0, NULL);

Pleae use the subsystem name in both function name and constant - like:
> +	ltt_ev_fs(LTT_EV_FS_BUF_WAIT_START, 0, 0, NULL);

This is commonly practice.

Comment is relevant for:
file_system	=>	fs
network		=>	net
memory		=>	mm

	Sam

      reply	other threads:[~2005-01-14 20:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-14  6:11 Karim Yaghmour
2005-01-14 20:49 ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050114204957.GB8385@mars.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@osdl.org \
    --cc=karim@opersys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ltt-dev@shafik.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®