From: Sam Ravnborg <sam@ravnborg.org>
To: Karim Yaghmour <karim@opersys.com>
Cc: Sam Ravnborg <sam@ravnborg.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
LTT-Dev <ltt-dev@shafik.org>
Subject: Re: [PATCH 2/8 ] ltt for 2.6.10 : core headers
Date: Fri, 14 Jan 2005 23:48:05 +0100 [thread overview]
Message-ID: <20050114224805.GA15192@mars.ravnborg.org> (raw)
In-Reply-To: <41E83F84.7080102@opersys.com>
> > Definitions used only internally by ltt shall stay in kernel/
> >
> > This is generally agreed upon, but not yet common practice.
>
> Should there be a kernel/ltt-core.h or should I just put all required
> definitions in kernel/ltt-core.c? The latter would result in a
> cluttered C file, I think. Though there aren't any .h's in kernel/,
> so I'm not sure what's the best way to proceed here.
The general approach here is to use a local .h files if there is
a considerable amount of definitions.
For a smaller set including them in the .c file is fine.
Sam
prev parent reply other threads:[~2005-01-14 22:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-14 6:11 Karim Yaghmour
2005-01-14 20:55 ` Sam Ravnborg
2005-01-14 21:54 ` Karim Yaghmour
2005-01-14 22:48 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050114224805.GA15192@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@osdl.org \
--cc=karim@opersys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ltt-dev@shafik.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome