mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: ak@suse.de, manpreet@fabric7.com, linux-kernel@vger.kernel.org,
	discuss@x86-64.org
Subject: Re: [PATCH] i386/x86-64: Fix timer SMP bootup race
Date: Fri, 14 Jan 2005 23:40:26 -0800	[thread overview]
Message-ID: <20050114234026.02feff01.akpm@osdl.org> (raw)
In-Reply-To: <1105774495.12263.21.camel@localhost.localdomain>

Rusty Russell <rusty@rustcorp.com.au> wrote:
>
>   static inline void do_timer_interrupt_hook(struct pt_regs *regs)
>   {
>  -	do_timer(regs);
>  +	/* i386 brings up CPU before core is setup. */
>  +	if (unlikely(!cpu_online(smp_processor_id())))
>  +		jiffies64++;
>  +	else
>  +		do_timer(regs);

I thik I preferred Andi's approach - it adds code which is largely dropped
from the memory.  This patch adds a test-n-branch to every timer interrupt..

  reply	other threads:[~2005-01-15  7:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-15  4:09 Andi Kleen
2005-01-15  5:09 ` Rusty Russell
2005-01-15  5:23   ` Andi Kleen
2005-01-15  7:34     ` Rusty Russell
2005-01-15  7:40       ` Andrew Morton [this message]
2005-01-15  7:59       ` Andi Kleen
2005-01-16  4:20         ` Rusty Russell
2005-01-16  5:34           ` Andi Kleen
2005-01-16  6:42             ` Rusty Russell
2005-01-15  6:28 ` Andrew Morton
2005-01-15  6:43   ` Andi Kleen
2005-01-15  6:54     ` Andrew Morton
2005-01-15  7:18       ` Andi Kleen
2005-01-17  2:34 ` Rusty Russell
2005-01-17  5:43   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050114234026.02feff01.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=ak@suse.de \
    --cc=discuss@x86-64.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manpreet@fabric7.com \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome