mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Tom Zanussi <zanussi@comcast.net>
Cc: Karim Yaghmour <karim@opersys.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	LTT-Dev <ltt-dev@shafik.org>
Subject: Re: [PATCH 4/4] relayfs for 2.6.10: headers
Date: Fri, 14 Jan 2005 16:50:01 -0800	[thread overview]
Message-ID: <20050115005001.GB9046@kroah.com> (raw)
In-Reply-To: <41E8282F.8060208@comcast.net>

On Fri, Jan 14, 2005 at 02:14:39PM -0600, Tom Zanussi wrote:
> Greg KH wrote:
> >On Thu, Jan 13, 2005 at 10:04:36PM -0500, Karim Yaghmour wrote:
> >
> >>+/**
> >>+ *	have_cmpxchg - does this architecture have a cmpxchg?
> >>+ *
> >>+ *	Returns 1 if this architecture has a cmpxchg useable by
> >>+ *	the lockless scheme, 0 otherwise.
> >>+ */
> >>+static inline int
> >>+have_cmpxchg(void)
> >>+{
> >>+#if defined(__HAVE_ARCH_CMPXCHG)
> >>+	return 1;
> >>+#else
> >>+	return 0;
> >>+#endif
> >>+}
> >
> >
> >Shouldn't this be a build time check, and not a runtime one?
> >
> 
> This was to avoid having an ifdef in the main body of the code.  It's 
> only used in channel setup, so I did'nt worrry about runtime checking.

This should all be set up properly for you anyway.  I don't think this
is needed at all.

thanks,

greg k-h

      reply	other threads:[~2005-01-15  0:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-14  3:04 Karim Yaghmour
2005-01-14 19:07 ` Greg KH
2005-01-14 20:05   ` Tom Zanussi
2005-01-14 19:10 ` Greg KH
2005-01-14 20:14   ` Tom Zanussi
2005-01-15  0:50     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050115005001.GB9046@kroah.com \
    --to=greg@kroah.com \
    --cc=karim@opersys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ltt-dev@shafik.org \
    --cc=zanussi@comcast.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®