From: Willy TARREAU <willy@w.ods.org>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.29-rc3
Date: Sat, 15 Jan 2005 22:43:31 +0100 [thread overview]
Message-ID: <20050115214330.GA765@pcw.home.local> (raw)
In-Reply-To: <20050115151320.GB7397@logos.cnet>
Hi Marcelo,
On Sat, Jan 15, 2005 at 01:13:20PM -0200, Marcelo Tosatti wrote:
> Hi,
>
> Here goes the third release candidate.
>
> This one comes out to release a bunch of pending networking fixes from
> David Miller: netfilter, sctp, ipvs, etc.
>
> Also changes the tty ldisc locking patches to not export a couple of API functions
> as GPL, because that breaks compatibility with older modutils.
>
> This will become final if no problems appear.
>
> Please help with testing!
OK, it builds and runs on my dual athlon (gcc-2.95.3,e1000,scsi), my
notebook (gcc-3.3.5,tg3,acpi), and on an ultra60 (ultrasparc SMP,gcc-3.3.4,
scsi,sunhme). I also built it on an alpha ev6 with gcc-3.3.5, but I didn't
want to reboot it.
While compiling, I noticed that hosts using gcc-3 gave a few warnings such
as this one, which is easily fixed with the following patch :
bond_alb.c: In function `bond_alb_xmit':
bond_alb.c:1278: warning: use of cast expressions as lvalues is deprecated
--- ./drivers/net/bonding/bond_alb.c.bad Sat Mar 20 10:08:18 2004
+++ ./drivers/net/bonding/bond_alb.c Sat Jan 15 22:14:32 2005
@@ -1275,7 +1275,7 @@
int bond_alb_xmit(struct sk_buff *skb, struct net_device *bond_dev)
{
struct bonding *bond = bond_dev->priv;
- struct ethhdr *eth_data = (struct ethhdr *)skb->mac.raw = skb->data;
+ struct ethhdr *eth_data = (struct ethhdr *)(skb->mac.raw = skb->data);
struct alb_bond_info *bond_info = &(BOND_ALB_INFO(bond));
struct slave *tx_slave = NULL;
static u32 ip_bcast = 0xffffffff;
> Summary of changes from v2.4.29-rc2 to v2.4.29-rc3
> ============================================
(...)
> Patrick McHardy:
> o [NETFILTER]: Associate locally generated ICMP errors with conntrack of original packet
> o [NETFILTER]: Remove CONFIG_IP_NF_NAT_LOCAL config option
at first, I though that both the config option and the feature were removed !
fortunately, it's only the option ;-)
Cheers,
Willy
prev parent reply other threads:[~2005-01-15 21:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-15 15:13 Marcelo Tosatti
2005-01-15 21:43 ` Willy TARREAU [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050115214330.GA765@pcw.home.local \
--to=willy@w.ods.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®