From: Christoph Hellwig <hch@lst.de>
To: akpm@osdl.org
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] switch frw to use local_soft_irq_pending
Date: Sun, 16 Jan 2005 12:58:41 +0100 [thread overview]
Message-ID: <20050116115841.GB13716@lst.de> (raw)
The newly merged frv do_IRQ code calls softirq_pending(), but always with
the current cpu as argument - switch to local_softirq_pending().
Btw, this usage look bogus to me, any reason you need to call do_softirq
again after you did four lines above in irq_exit(), David?
--- 1.1/arch/frv/kernel/irq.c 2005-01-05 03:48:04 +01:00
+++ edited/arch/frv/kernel/irq.c 2005-01-07 12:27:31 +01:00
@@ -312,7 +312,7 @@
/* only process softirqs if we didn't interrupt another interrupt handler */
if ((__frame->psr & PSR_PIL) == PSR_PIL_0)
- if (softirq_pending(cpu))
+ if (local_softirq_pending())
do_softirq();
#ifdef CONFIG_PREEMPT
next reply other threads:[~2005-01-16 11:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-16 11:58 Christoph Hellwig [this message]
2005-01-17 12:14 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050116115841.GB13716@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome